feat(registry): add AES-CTR-HMAC-SHA1-96 suite pattern (RFC 3686) #771
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cloneDX#770) Signed-off-by: Mehrn0ush <[email protected]>
Member
stevespringett
added
cap: cryptography
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the AES-CTR-HMAC-SHA1-96 cipher suite pattern to the CycloneDX Cryptography Registry, addressing issue #770. This is an IPsec ESP-style authenticated encryption suite combining AES Counter mode with HMAC-SHA1 authentication using 96-bit tags.
Changes:
- Added new AES variant pattern
AES[-(128|192|256)]-CTR-HMAC-SHA1[-96]with primitive typeae(authenticated encryption) - Added RFC 3686 as the standard reference with appropriate DOI URL
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ], | ||
| "pattern": "AES[-(128|192|256)]-CTR-HMAC-SHA1[-96]", | ||
| "primitive": "ae" | ||
| }, |
There was a problem hiding this comment.
This line has trailing whitespace after the closing brace and comma. Trailing whitespace should be removed to maintain consistent formatting throughout the file.
Suggested change
| }, | |
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in ticket #770, this PR proposes adding an AES-CTR + HMAC-SHA1-96 (IPsec ESP suite-style) pattern to the Cryptography Registry.
Fixes #770
Details
AES[-(128|192|256)]-CTR-HMAC-SHA1[-96]under the existingAESfamily.schema/cryptography-defs.json). No schema or specification behavior changes.